feat: add --dry-run arg#8
Open
robotrory wants to merge 1 commit into
Open
Conversation
samstarling
approved these changes
May 1, 2026
Contributor
There was a problem hiding this comment.
This looks good! One thing to consider is whether we want to split up "global" options from everything else. Now that *CLI gets passed into Run(), BuildPushCmd gets access to things like Auth which ideally it shouldn't need to know anything about.
I think we could solve this by doing something like:
type Globals struct {
Debug bool
JSON bool
Quiet bool
DryRun bool
}
type CLI struct {
Globals
Version kong.VersionFlag
Auth AuthCmd `cmd:""`
Build BuildCmd `cmd:""`
}
// Then in main:
kong.Parse(&cli, kong.Vars{...}, kong.Bind(&cli.Globals))
// And in subcommands:
func (c *BuildPushCmd) Run(g *Globals) error { ... }Not a must-fix by any means, but probably nice to do as we scale the number of commands in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--dry-runarg so that we can test validation without making real network calls.