Feature : add 'size' option for custom dropdown height#1875
Merged
risadams merged 4 commits intoselectize:masterfrom Sep 27, 2022
fabienwnklr:master
Merged
Feature : add 'size' option for custom dropdown height#1875risadams merged 4 commits intoselectize:masterfrom fabienwnklr:master
risadams merged 4 commits intoselectize:masterfrom
fabienwnklr:master
Conversation
|
Some time ago I needed this too. I solved this with 1 line of CSS: .my-selectize .selectize-dropdown-content {
max-height: none !important;
}or .my-selectize .selectize-dropdown-content {
max-height: 450px !important;
}I particularly think that this kind of problem should be solved via CSS not JS. |
Contributor
Author
|
Yes for simple height it's easily doable with CSS,I implemented that CSS values be accepted for better customization and flexibility. But first improvement and first idea it's to set a count of visible value, like 5 items visible etc. Let's see what owner think about that ! |
risadams
suggested changes
Sep 24, 2022
Contributor
risadams
left a comment
There was a problem hiding this comment.
Got a couple of questions here. Also Thanks for adding tests! :)
risadams
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new 'size' option to set dropdown size, can be a number to displayed items, or a simple CSS height (px, rem, em, vh)
I also added two tests for value as number of items displayed and CSS value
Default value is
falseso nothing changeOpen to improvement and patch