ENH: Final PR for Python bindings for Seldon (GSOC'24)#2
Conversation
|
Please rebase these with the identifiers. |
HaoZeke
left a comment
There was a problem hiding this comment.
Please lint this, and apart from a few comments, looks very promising. Lets get this in this week, and move forward to a CI test of this
| #include "model.hpp" | ||
| #include "model_factory.hpp" | ||
| #include "models/ActivityDrivenModel.hpp" | ||
| #include "models/DeGroot.hpp" | ||
| #include "models/DeffuantModel.hpp" | ||
| #include "models/InertialModel.hpp" | ||
| #include "network.hpp" | ||
| #include "simulation.hpp" |
There was a problem hiding this comment.
Nit -> nicer to have the scoping project, so models/DeGroot.hpp -> seldon/models/DeGroot.hpp
Flowy had a similar refactor / reworking for this
HaoZeke
left a comment
There was a problem hiding this comment.
Please lint this, and apart from a few comments, looks very promising. Lets get this in this week, and move forward to a CI test of this
Helps with cibuildwheel too :) Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Also bump ubuntu version Co-authored-by: User-DK <User-DK@users.noreply.github.com>
Co-authored-by: User-DK <User-DK@users.noreply.github.com>
MAINT: Setup integration with `cibuildwheel`
|
Please rename everything to PsiSeldon :) |
There was a problem hiding this comment.
Comment that this is to simulate an incorrect config for a test? Also as noted, perhaps an in-code fix for this, reading in the correct config, and changing a value to an incorrect one for a key before the test.
There was a problem hiding this comment.
Replace with myst markdown please.
There was a problem hiding this comment.
Replace with myst markdown please.
There was a problem hiding this comment.
Replace with myst markdown please.
| project = 'pyseldonlib' | ||
| copyright = '2024, PySeldon Developers' | ||
| author = 'Amrita Goswami, Daivik Karbhari, Moritz Sallermann, Rohit Goswami' | ||
| release = '1.0' |
There was a problem hiding this comment.
Will be done later, once dynamic release is setup.
HaoZeke
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the work on this!
This work is a part of Google Summer of Code 2024 under the Python Software Organisation. The aim of this project is to create Python bindings for the Seldon framework. The Seldon framework is a C++ Engine for Opinion Dynamics. The bindings and the complete project as a python package will allow users to use the Seldon framework in Python and carry out Simulations.
The Goals of the project were as Follows: