Skip to content

Fix integration slugs#462

Closed
XavierAgostini wants to merge 9 commits intomasterfrom
fix-integration-slugs
Closed

Fix integration slugs#462
XavierAgostini wants to merge 9 commits intomasterfrom
fix-integration-slugs

Conversation

@XavierAgostini
Copy link
Contributor

Proposed changes

  • Adjusts catalog script to generate integration slug based on catalog name rather than display name
  • there might be some stub files that need to be cleaned up

Related issues (optional)

Fixes #406



if (slug === 'active-campaign') slug = 'activecampaign'
if (slug === 'adwords') slug = 'google-ads'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be google-ads-classic?

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a spot check, and something's not quite right with the Google-ads-classic/adwords one, other than that this is alot better!
image

@sanscontext
Copy link
Contributor

Hey @XavierAgostini , when I run make catalog on this branch, it's also renaming the sources. I think this is fine for now since we're not pulling much source metadata, but would it be difficult to add a separator so we can keep the destination and cloud-source renames separate?

sanscontext and others added 2 commits January 17, 2020 16:52
Signed-off-by: sanscontext <lrubin@segment.com>
@sanscontext
Copy link
Contributor

Closing this out per discussion - we do want to keep the display-name the slugified part, and move docs to match a rename. I'm going to go through and make sure that all the correct things are doing the right stuff in the docs, then make sure that the links to docs, as explained in the Partner Portal, are linking to the right thing.

@sanscontext sanscontext deleted the fix-integration-slugs branch March 19, 2020 23:56
bot-docsteam added a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatched names and slugs prevent integration-foot content from showing

2 participants