Skip to content

fix(android): fix crash when promise resolves in debug mode #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsneed merged 3 commits into from
Feb 8, 2021
Merged

fix(android): fix crash when promise resolves in debug mode #267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4489603
fix(android): fix crash when promise resolves in debug mode
Feb 3, 2021
6891105
fix(ci): update config.yml
bsneed Feb 4, 2021
0bbd476
Merge branch 'master' into bsneed/promise_crash
bsneed Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM
}
else {
if (BuildConfig.DEBUG) {
return promise.resolve(this)
return promise.resolve(null)
}
else {
return promise.reject("E_SEGMENT_RECONFIGURED", "Segment Analytics Client was allocated multiple times, please check your environment.")
Expand Down