Skip to content

please, fix build.graddle!#22

Closed
juliandondero wants to merge 3 commits intosegmentio:masterfrom
juliandondero:patch-1
Closed

please, fix build.graddle!#22
juliandondero wants to merge 3 commits intosegmentio:masterfrom
juliandondero:patch-1

Conversation

@juliandondero
Copy link

please, fix build.graddle y can't use the google analytics integration in android, the project name is wrong

please, fix build.graddle y can't use the google analytics integration in android, the project name is wrong
@iyogeshjoshi
Copy link

@fathyb can you please review the change and merge it, it's breaking my code for long time now.

@f2prateek
Copy link
Contributor

We'll take a look soon!

Copy link
Contributor

@fathyb fathyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juliandondero, we are already testing that Gradle project identifiers are correct in Android E2E tests, this includes all integrations. I’ve pushed your branch to our remote so that it triggers CI checks; the Android tests are failing: https://circleci.com/gh/segmentio/analytics-react-native/937.

You can manually check that these tests are working locally by running yarn && yarn build && yarn test-app test:android.

I suspect that the Gradle version changes how project identifiers are generated. What Gradle version are you using? E2E tests are using 4.4.
If that's the culprit, we could add some logic to build.gradle to require the right project dynamically based on the version.

@iyogeshjoshi
Copy link

@fathyb hey I'm using same Gradle version 4.4 it's still breaking for me, though changing the path i.e, replacing _ with / works for me. I'm not sure either why it is failing on CI.

@bsneed
Copy link
Contributor

bsneed commented Mar 19, 2020

Made this change in PR #147, seems to be working/building fine.

@bsneed bsneed closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants