Deploy tree: bind checkbox labels to per-node input IDs#709
Open
benhegartysefe with Copilot wants to merge 3 commits into
Open
Deploy tree: bind checkbox labels to per-node input IDs#709benhegartysefe with Copilot wants to merge 3 commits into
benhegartysefe with Copilot wants to merge 3 commits into
Conversation
2 tasks
Copilot
AI
changed the title
[WIP] Fix checkbox labels to reference input ID for better usability
Deploy tree: bind checkbox labels to per-node input IDs
May 28, 2026
benhegartysefe
marked this pull request as ready for review
May 28, 2026 15:27
benhegartysefe
approved these changes
May 28, 2026
kirill-suspitsin-ext-sefe
approved these changes
May 28, 2026
NishilRaichura
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Deploy components tree, checkbox labels were not associated with their corresponding inputs (
label forpointed at a non-matching value), so clicking component text did not toggle selection. This updates checkbox/label wiring to use matching, node-specific IDs so label text is a valid hit target everywhere this tree node renderer is used.Checkbox/label association in tree node template
id/labelforvalues with a shared computed ID per node.<label>targets its own<input>in the recursive component tree.Stable per-node input ID generation
deploymentInputIdonHegsTreeNode, derived fromdata.idwith an instance fallback when needed.Input lookup compatibility
#deploymenttoinput[type="checkbox"]to match dynamic IDs.Focused coverage for regression prevention
input.id === label.forfor rendered nodes.