Expand SSH Finding Model into multiple Categories

[J12934]

General Changes

• Change empty string fields like hostname and server_banner to null values
• The location of the findings will now be equal to the hostname (if existing), falling back to the ip_address if not set.
• All findings now have hostname and ip_address fields in their attributes map.
• Split out the finding categories. Currently all SSH Scanner findings are of the category SSH Service. This category will be kept for the general purpose informational finding. The other "policy violation" type findings will be moved into their own category. The changes to these two categories are grouped below

Changes to SSH Service Category Findings

• Added extra attributes for supported auth_methods, key_algorithms, encryption_algorithms, mac_algorithms & compression_algorithms to easily see all relevant informations about the ssh server

Changes to Policy Violation Type Findings

• These findings were previously also in the SSH Service Category but will now be moved into the SSH Policy Violation Category
• Which kind of policy was violated can be identified by the findings name. The following names are possible:
  • Insecure Methods / Algorithms:
    • Discouraged SSH Authentication Method
    • Insecure SSH Key Algorithms
    • Insecure SSH Encryption Ciphers
    • Insecure SSH MAC Algorithms
    • Insecure SSH Compression Algorithms
  • Missing Methods / Algorithms:
    • Missing SSH Authentication Method
    • Missing SSH Key Algorithms
    • Missing SSH Encryption Ciphers
    • Missing SSH MAC Algorithms
    • Missing SSH Compression Algorithms
  • Outdated SSH Protocol Version
• These findings have a payload field in their attributes map which indicates which kind of key algorithms, encryption ciphers or other are in violation of the policy.
• The description contains the original ssh_scan recommendation text.

[J12934]

I refuse to accept the last codacity issue, (that the get_policy_violation_type is too complex). I think their cyclomatic complexity calculation logic really doesn't like case statements.

[rfelber]

Im not sure about the port change but beside that it seems to be good.