This repository was archived by the owner on Feb 26, 2021. It is now read-only.
Conversation
Instead of doing a second xml parsing run.
SirDany
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 New Host Type Findings
Previously only Open Ports would be used to create Findings. This works great but is lacking if you want to use Nmap for Network Discovery where you don't care about ports but only if the hosts are up or not.
To accommodate this use case we added a new finding type of the category
Host. These contain the following information:{ "id": "49bf7fd3-8512-4d73-a28f-608e493cd726", "category": "Host", "name": "Host: localhost", "description": "Found a host", "location": "localhost", "osi_layer": "NETWORK", "severity": "INFORMATIONAL", "attributes": { "hostname": "localhost", "ip_address": "127.0.0.1", "operating_system": null } }🚧 Technical Changes
To allow these change, mayor restructuring was required, most notably the extraction of the
node-nmappackage into this repository to make the required changes to the result parsing.This also allowed to move the nmap script result parsing into this code, which means that we don't have to parse the xml twice anymore.