Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

Add Hosts as new Finding Category#21

Merged
SirDany merged 21 commits intomasterfrom
custom-nmap-parser
Aug 21, 2019
Merged

Add Hosts as new Finding Category#21
SirDany merged 21 commits intomasterfrom
custom-nmap-parser

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Jun 29, 2019

🚀 New Host Type Findings

Previously only Open Ports would be used to create Findings. This works great but is lacking if you want to use Nmap for Network Discovery where you don't care about ports but only if the hosts are up or not.

To accommodate this use case we added a new finding type of the category Host. These contain the following information:

{
  "id": "49bf7fd3-8512-4d73-a28f-608e493cd726",
  "category": "Host",
  "name": "Host: localhost",
  "description": "Found a host",
  "location": "localhost",
  "osi_layer": "NETWORK",
  "severity": "INFORMATIONAL",
  "attributes": {
    "hostname": "localhost",
    "ip_address": "127.0.0.1",
    "operating_system": null
  }
}

🚧 Technical Changes

To allow these change, mayor restructuring was required, most notably the extraction of the node-nmap package into this repository to make the required changes to the result parsing.
This also allowed to move the nmap script result parsing into this code, which means that we don't have to parse the xml twice anymore.

@J12934 J12934 added the enhancement New feature or request label Jun 29, 2019
@J12934 J12934 self-assigned this Jun 29, 2019
@J12934 J12934 requested a review from SirDany August 21, 2019 08:11
@J12934 J12934 marked this pull request as ready for review August 21, 2019 08:12
@SirDany SirDany merged commit 2dc3d90 into master Aug 21, 2019
@J12934 J12934 deleted the custom-nmap-parser branch August 21, 2019 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants