-
Notifications
You must be signed in to change notification settings - Fork 12
#35 Test create and publish a release with automatic semantic versioning #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Weltraumschaf
merged 10 commits into
secureCodeBox:main
from
Zero3141:fix/failing-pipeline
Aug 1, 2023
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4addafb
Run tests on each pull request instead of push to main
af10ee2
Add PRs and workflow dispatch as test ci triggers
58aebd8
Refactor github workflows
ab0b622
Remove unshallow parameter
fb4a3d7
Split release workflow into two jobs
c1ff671
Add gradle wrapper validation to test workflow
7a28b04
Add explanation for "Get current version" step in release workflow
586ba69
Replace manual git fetch with fetch-depth of 0 in checkout step
8f36228
Bump pl.allegro.tech.build.axion-release from 1.15.1 to 1.15.4
1be22dd
Update deprecated output setting syntax
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment before this step to explain its purpose & functionality. Is this sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good starting point for the reason, but there should also be some info about the concrete syntax (
::set-output name=version::). If you have a link which describes this, a link with a hint that it describes the syntax is sufficient.