Skip to content

Change 'ResouceType' to 'Collection'#291

Merged
adwydman merged 3 commits intoalphafrom
change_resouceType_to_collection
Aug 16, 2016
Merged

Change 'ResouceType' to 'Collection'#291
adwydman merged 3 commits intoalphafrom
change_resouceType_to_collection

Conversation

@kuba-orlik
Copy link
Member

This is a breaking API change. Now you create what was previously known as a ResourceType like so:

new Sealious.Collection({...declaration

Please note that this change required updating the https://github.com/sealcode/sealious-integration-tests. I've pushed the necessary changes to the integration tests into the alpha branch of it's repo.

@kuba-orlik kuba-orlik force-pushed the change_resouceType_to_collection branch from bee3c7b to 7d1c246 Compare August 15, 2016 11:40
@adwydman
Copy link
Member

I think there were no tests for ResourceType, are you sure that this change doesn't break anything?

@kuba-orlik
Copy link
Member Author

Integration tests pass! That means that the relations between the channels and collections are kept intact :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.343% when pulling 0a3a3d7 on change_resouceType_to_collection into f3e7d0c on alpha.

@adwydman
Copy link
Member

All right, merging.

@adwydman adwydman merged commit 0a3a3d7 into alpha Aug 16, 2016
@adwydman adwydman deleted the change_resouceType_to_collection branch August 16, 2016 09:43
@adwydman
Copy link
Member

@kuba-orlik Remember to adjust the documentation and user guide. :)

@kuba-orlik kuba-orlik restored the change_resouceType_to_collection branch August 16, 2016 09:46
@kuba-orlik
Copy link
Member Author

sealcode/sealious-user-reference#2 I've updated the user-reference :)

@kuba-orlik
Copy link
Member Author

(please, review it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants