Skip to content

MAINT Directly cimport stack from Cython#29228

Merged
adrinjalali merged 2 commits into
scikit-learn:mainfrom
adam2392:cython
Jun 10, 2024
Merged

MAINT Directly cimport stack from Cython#29228
adrinjalali merged 2 commits into
scikit-learn:mainfrom
adam2392:cython

Conversation

@adam2392

@adam2392 adam2392 commented Jun 10, 2024

Copy link
Copy Markdown
Member

Reference Issues/PRs

n/a

What does this implement/fix? Explain your changes.

  • directly imports the stack from Cython 3.0+

Any other comments?

Noticed this when I was hacking some of the Cython internal tree code. This should be an extremely quick review.

Signed-off-by: Adam Li <adam2392@gmail.com>
@github-actions

github-actions Bot commented Jun 10, 2024

Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 37bf2b9. Link to the linter CI: here

@adrinjalali adrinjalali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@adam2392

Copy link
Copy Markdown
Member Author

The CIs do not pass, but upon glance, they do not look related? Perhaps some issue with pulling some files from an online API?

https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=67450&view=logs&j=f71949a9-f9d9-549e-cf45-2e99c7b412d1&t=11e6ea3b-68dc-5625-4d2d-1b8393fea9ee&l=149

@adrinjalali adrinjalali merged commit 8132683 into scikit-learn:main Jun 10, 2024
@adam2392 adam2392 deleted the cython branch June 10, 2024 22:14
@lesteve

lesteve commented Jun 11, 2024

Copy link
Copy Markdown
Member

The CIs do not pass, but upon glance, they do not look related? Perhaps some issue with pulling some files from an online API?

For the record, this looks like fetch_california_housing HTTP 403, I added #28297 (comment) to mention it in the original issue.

@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants