Merged
Conversation
This was referenced Jan 14, 2021
With this setting, tests pass on command line. TODO: clean-up
Member
Author
|
I was able to get the unit tests to work on the command line. The issue was the surefire plugin that would use a manifest-only jar that would contain the classpath. For some reason, the order in which the jars were listed in that manifest-only jar caused the issues described in the Kotlin Discourse linked in the initial PR comment. I was able to fix this issue by setting <properties>
<surefire.useManifestOnlyJar>false</surefire.useManifestOnlyJar>
</properties>For more details on that surefire property, see |
Member
|
Thanks a lot, @hanslovsky! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Kotlin scripting engine and re-implements in Kotlin while at it. The major issues were
pom.xml.Status:
Fiji.app/jarsand confirmed that it worked: imklib