ThreadService: add API for backing ExecutorService#173
Merged
Conversation
Member
Author
|
@dietzc Happy Thursday. |
Contributor
|
thanks so much @ctrueden |
For some uses cases (particularly for certain calls to ImgLib2 functionality), it is helpful to have access to the ExecutorService being used internally by the ThreadService. And while we're at it, we may as well make the ExecutorService itself configurable. I have a vague intuition that ExecutorService is probably not applicable to all threading models of all possible sorts of Java runtimes, so I include a caveat in the javadoc that the accessor is allowed to return null, and the mutator is allowed to throw UnsupportedOperationException, if the ThreadService implementation does not use an ExecutorService.
42f8cb3 to
6977b52
Compare
ctrueden
added a commit
that referenced
this pull request
Jun 25, 2015
ThreadService: add API for backing ExecutorService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some uses cases (particularly for certain calls to ImgLib2 functionality), it is helpful to have access to the ExecutorService being used internally by the ThreadService. And while we're at it, we may as well make the ExecutorService itself configurable.
I have a vague intuition that ExecutorService is probably not applicable to all threading models of all possible sorts of Java runtimes, so I include a caveat in the javadoc that the accessor is allowed to return null, and the mutator is allowed to throw UnsupportedOperationException, if the ThreadService implementation does not use an ExecutorService.