Add an XmlAttributeMap

[adrienbrault]

Hi,

I needed this, so I share it.

I'm not sure if the results i'm expecting for the json and yaml formats are right.
In the tests i expect:

attributes:
    name: firstname
    value: Adrien

But should it be

name: firstname
value: Adrien

Any feedback is welcome.

[schmittjoh]

Did you check @XmlKeyValuePairs? After a quick look, it looks like what you are proposing.

[adrienbrault]

Just checked it, it doesnt produce the expected XML.

I'm using this class:

<?php

/**
 * @Serializer\XmlRoot("input")
 */
class Input
{
    /**
     * @Serializer\XmlAttributeMap
     */
    public $attributes = array(
        'type' => 'integer',
        'value' => '1',
        'name' => 'search[page]',
    );
}

With @XmlKeyValuePairs I get

<input>
    <attributes>
        <type>
            <![CDATA[integer]]>
        </type>
        <value>
            <![CDATA[1]]>
        </value>
        <name>
            <![CDATA[search[page]]]>
        </name>
    </attributes>
</input>

Whereas with @XmlAttributeMap I get what i want :

<input type="integer" value="1" name="search[page]"/>

[adrienbrault]

@schmittjoh ? Is there something missing in my implementation, tests ?

[schmittjoh]

Looks good, could you rebase this on latest master?

It should only require a minor update in the base test case.

[adrienbrault]

Rebase on master done

[schmittjoh]

Did you add the Traversable check here?

[adrienbrault]

Huh ? !$v instanceof \Traversable

[schmittjoh]

Just asking because I've removed the special handling for traversables in the master branch. However, in that case we can probably keep it.

Could you add an extra test case to avoid regressions?

[adrienbrault]

I'm going to remove the Traversable handling, because YamlSerializationVisitor::75 uses array_keys. On a Traversable object it fails.

[adrienbrault]

@schmittjoh I removed the Traversable handling, and added a test in XmlSerializationTest.php to check an exception is thrown

[schmittjoh]

Thanks, merged!