Skip to content

patch service config identifier #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saiatmakuri merged 1 commit into from
May 4, 2024
Merged

patch service config identifier #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/model-engine/templates/inference_framework_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: model-engine-inference-framework-latest-config
name: {{ include "modelEngine.fullname" . }}-inference-framework-latest-config
labels:
product: common
team: infra
Expand Down
6 changes: 5 additions & 1 deletion model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,11 @@
NUM_DOWNSTREAM_REQUEST_RETRIES = 80 # has to be high enough so that the retries take the 5 minutes
DOWNSTREAM_REQUEST_TIMEOUT_SECONDS = 5 * 60 # 5 minutes

LATEST_INFERENCE_FRAMEWORK_CONFIG_MAP_NAME = "model-engine-inference-framework-latest-config"
SERVICE_NAME = "model-engine"
SERVICE_IDENTIFIER = os.getenv("SERVICE_IDENTIFIER")
Copy link
Copy Markdown
Contributor

@yunfeng-scale yunfeng-scale May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we already have a name in helm chart that is model-engine-{SERVICE_IDENTIFIER}?

Copy link
Copy Markdown
Contributor Author

@saiatmakuri saiatmakuri May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not find it

if SERVICE_IDENTIFIER:
SERVICE_NAME += f"-{SERVICE_IDENTIFIER}"
LATEST_INFERENCE_FRAMEWORK_CONFIG_MAP_NAME = f"{SERVICE_NAME}-inference-framework-latest-config"


def count_tokens(input: str, model_name: str, tokenizer_repository: TokenizerRepository) -> int:
Expand Down