Skip to content

Add retries to deflake integration tests #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squeakymouse merged 1 commit into from
Mar 19, 2024
Merged

Add retries to deflake integration tests #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration_tests/rest_api_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ def get_model_endpoint(name: str, user_id: str) -> Dict[str, Any]:
return response.json()["model_endpoints"][0]


@retry(stop=stop_after_attempt(3), wait=wait_fixed(20))
def update_model_endpoint(
endpoint_name: str, update_model_endpoint_request: Dict[str, Any], user_id: str
) -> Dict[str, Any]:
Expand Down
16 changes: 9 additions & 7 deletions integration_tests/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ def ensure_async_inference_works(user, create_endpoint_request, inference_payloa
ensure_all_async_tasks_success(task_ids, user, return_pickled)


@retry(stop=stop_after_attempt(3), wait=wait_fixed(20))
def ensure_endpoint_updated(create_endpoint_request, update_endpoint_request, user):
endpoint = get_model_endpoint(create_endpoint_request["name"], user)
assert endpoint["resource_state"]["cpus"] == update_endpoint_request["cpus"]
assert endpoint["resource_state"]["memory"] == update_endpoint_request["memory"]
assert endpoint["deployment_state"]["max_workers"] == update_endpoint_request["max_workers"]


@pytest.mark.parametrize(
"create_endpoint_request,update_endpoint_request,inference_requests",
[
Expand Down Expand Up @@ -99,13 +107,7 @@ def test_async_model_endpoint(
ensure_n_ready_endpoints_short(1, user)

print("Checking endpoint state...")
endpoint = get_model_endpoint(create_endpoint_request["name"], user)
assert endpoint["resource_state"]["cpus"] == update_endpoint_request["cpus"]
assert endpoint["resource_state"]["memory"] == update_endpoint_request["memory"]
assert (
endpoint["deployment_state"]["max_workers"]
== update_endpoint_request["max_workers"]
)
ensure_endpoint_updated(create_endpoint_request, update_endpoint_request, user)

time.sleep(20)

Expand Down