Skip to content

Some updates to integration tests #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunfeng-scale merged 5 commits into from
Nov 17, 2023
Merged

Some updates to integration tests #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c40d0f
Some updates to integration tests
yunfeng-scale Nov 17, 2023
090adca
fix
yunfeng-scale Nov 17, 2023
7dbcb91
comment
yunfeng-scale Nov 17, 2023
0ef16ab
better env var
yunfeng-scale Nov 17, 2023
0f44e1b
Merge branch 'main' into yunfeng-integration-tests
yunfeng-scale Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions integration_tests/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import time

import pytest
from model_engine_server.common.env_vars import CIRCLECI
from tenacity import RetryError, retry, retry_if_exception_type, stop_after_attempt, wait_fixed

from .rest_api_utils import (
Expand Down Expand Up @@ -237,7 +236,9 @@ def test_sync_streaming_model_endpoint(capsys):
delete_model_endpoint(create_endpoint_request["name"], user)


@pytest.mark.skipif(CIRCLECI, reason="skip on circleci since need to figure out s3 access")
@pytest.mark.skipif(
Copy link
Copy Markdown
Contributor Author

@yunfeng-scale yunfeng-scale Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saiatmakuri FYI, i don't think this sounds as an integration test. can consider checking # tokens from responses?

Copy link
Copy Markdown
Contributor

@saiatmakuri saiatmakuri Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah can skip for now. essentially want to check if every tokenizer can be made before each deploy

Copy link
Copy Markdown
Contributor Author

@yunfeng-scale yunfeng-scale Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently fails for me since initdb is not in bash container. can be fixed by adding postgres there

reason="Need to update the following test to hit remote service to be integration test"
)
def test_models_tokenizers() -> None:
from model_engine_server.infra.gateways.s3_llm_artifact_gateway import S3LLMArtifactGateway
from model_engine_server.infra.repositories import LiveTokenizerRepository
Expand Down
5 changes: 5 additions & 0 deletions integration_tests/test_fine_tunes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import time

import boto3
import pytest
import smart_open

from .rest_api_utils import (
Expand All @@ -19,6 +20,10 @@
MAX_RETRIES = 10


@pytest.mark.skipif(
not os.getenv("FINE_TUNE_TEST_READY"),
reason="Skipping fine tune tests when test templates are not set up.",
)
def test_fine_tunes() -> None:
di_batch_job_id = create_docker_image_batch_job_bundle(
CREATE_FINE_TUNE_DI_BATCH_JOB_BUNDLE_REQUEST, USER_ID_0
Expand Down