Skip to content

Allow fine-tuning hyperparameter to be Dict #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squeakymouse merged 2 commits into from
Oct 26, 2023
Merged

Allow fine-tuning hyperparameter to be Dict #353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d951cf
add dict type
squeakymouse Oct 25, 2023
c293997
Merge branch 'main' into katiewu/add-fine-tune-hyperparameter-dict
squeakymouse Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions model-engine/model_engine_server/domain/entities/common_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from typing import Union
from typing import Any, Dict, Union

CpuSpecificationType = Union[str, int, float]
StorageSpecificationType = Union[str, int, float] # TODO(phil): we can make this more specific.
FineTuneHparamValueType = Union[str, int, float] # should suffice for now
FineTuneHparamValueType = Union[
str, int, float, Dict[str, Any]
] # should just make this Any if we need to add more