Import errors when there both a .css and .scss file in the specified location.

[dbatiste]

Given dependency path that has both:

foo.css
foo.scss

Attempting to import foo.scss in a dependent file:

@import 'foo';

results in an error:

{
"message": "It's not clear which file to import for '@import "foo"'.\nCandidates:\n foo.scss\n foo.css\nPlease delete or rename all but one of these files.\n",
"column": 1,
"line": 1,
"file": "application.scss",
"status": 1
}

This worked prior to the recent update. Is this change intentional, bug? Explicitly specifying the extension in the @import statement resolves the issue for a particular case, however this is breaking for many components.

[mgreter]

This is intentional and equal to how ruby sass handles this case.

[austinsmorris]

I am also getting this issue when there is two .scss files, but one is proceeded with an underscore. For example:

@import "path/to/foo";

And then in the /path/to/ directory, I have both foo.scss and _foo.scss.

This was working prior to 3.4.0.

[xzyfer]

There are two separate issues here. Each of the foo files contains only a comment with the filename.

---

First, error when an importing foo with both foo.scss and _foo.scss available.

$ ls -l
total 32
-rw-r--r--  1 michael  staff  13 27 Oct 23:36 _foo.scss
-rw-r--r--  1 michael  staff  10 27 Oct 23:36 foo.scss

$ echo "@import 'foo'" | sass -s
Error: It's not clear which file to import for '@import "foo"'.
       Candidates:
         _foo.scss
         foo.scss
       Please delete or rename all but one of these files.
        on line 1 of standard input
  Use --trace for backtrace.

Error: It's not clear which file to import for '@import \"foo\"'.
       Candidates:
         _foo.scss
         foo.scss
       Please delete or rename all but one of these files.
        on line 1 of stdin
>> @import 'foo'
   ^

In this case we're doing exactly what Ruby Sass does. The old working behaviour was a bug that has been fixed.

---

First, error when an importing foo with both foo.scss and foo.css` available.

$ ls -l
total 32
-rw-r--r--  1 michael  staff  13 27 Oct 23:36 foo.css
-rw-r--r--  1 michael  staff  10 27 Oct 23:36 foo.scss

$ echo "@import 'foo'" | sass -s
DEPRECATION WARNING: Importing from the current working directory will not be
automatic in future versions of Sass.  To avoid future errors, you can add it
to your environment explicitly by setting `SASS_PATH=.`, by using the -I command
line option, or by changing your Sass configuration options.

/* foo.scss */

$ echo "@import 'foo'" | ./node_modules/.bin/node-sass
Error: It's not clear which file to import for '@import \"foo\"'.
       Candidates:
         foo.scss
         foo.css
       Please delete or rename all but one of these files.
        on line 1 of stdin
>> @import 'foo'
   ^

We are incorrect here. This is a bug we need to fix.

[mgreter]

This is the case because libsass allows embeddable CSS partials by default. If you enable this for ruby sass, you will get the same error too. Only improvement I would see is to add a config option to enable/disable this feature, as I have suggested before.

[xzyfer]

I agree, we should add the flag and have it disabled by default to match the Ruby behaviour.

[rankida]

This has caused us great issues in our project and have had to revert back to 3.3.0 in the mean time.

I would vote for the feature to be turned off/on, though I am surprised that the default is on. Indeed I am surprised that when given the option of filename.scss and filename.css the .scss doesn't simply win by default.

Must say, good work and thanks to the project team - node-sass is great!

[xzyfer]

I've created sass/libsass#1656 to track this fix in LibSass.

[hkassam]

I would actually suggest that, since this is a breaking change with the way it was working before, it required a major version bump (as this change breaks every project that references node-sass in their package.json as "^3.x.y").