refactoring tests with mock servers (#30)#356
Merged
sashabaranov merged 1 commit intosashabaranov:masterfrom Jun 12, 2023
Merged
refactoring tests with mock servers (#30)#356sashabaranov merged 1 commit intosashabaranov:masterfrom
sashabaranov merged 1 commit intosashabaranov:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 17 17
Lines 670 670
=======================================
Hits 638 638
Misses 22 22
Partials 10 10 |
Collaborator
Author
|
@sashabaranov Please check it. |
sashabaranov
approved these changes
Jun 12, 2023
Owner
sashabaranov
left a comment
There was a problem hiding this comment.
Love the new API, thank you so much! 🙌🏻
+731 −1,060 👀
coggsfl
added a commit
to coggsfl/go-openai
that referenced
this pull request
Jun 12, 2023
refactoring tests with mock servers (sashabaranov#30) (sashabaranov#356)
coggsfl
pushed a commit
to coggsfl/go-openai
that referenced
this pull request
Jun 12, 2023
10 tasks
coggsfl
pushed a commit
to coggsfl/go-openai
that referenced
this pull request
Jun 13, 2023
coggsfl
pushed a commit
to coggsfl/go-openai
that referenced
this pull request
Jun 13, 2023
sashabaranov
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Improve (#356) to support registration of wildcard URLs * Add TestAzureChatCompletions & TestAzureChatCompletionsWithCustomDeploymentName * Remove TestAzureChatCompletionsWithCustomDeploymentName --------- Co-authored-by: coggsflod <richard.coggins@officedepot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve #30
Boilerplate for tests using mock server aggregated into the following function.
setupOpenAITestServer() (client *Client, server *test.ServerTest, teardown func())setupAzureTestServer() (client *Client, server *test.ServerTest, teardown func())This refactoring removed a lot of duplicate test code.
And I split some test files with names like
xxx_api_test.goto avoid circular import.