move pytest options from pytest config to tox#156
Merged
oz123 merged 1 commit intosarugaku:masterfrom Jan 28, 2024
Merged
Conversation
The --cov option was useless, since tox already uses `coverage run` instead. While we are at it, we can also drop pytest-cov from the test dependencies. One less wheel for tox to download and install. The timeout option is moved to tox. Both of these options add additional dependencies for running `pytest` outside of tox, which may sometimes be desired if you really know what you are doing. There is no way to disable them other than by patching out the addopts configuration. Best to specify this only in tox, which is designed to set up the appropriate environments already. Bug: https://bugs.gentoo.org/922192
oz123
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --cov option was useless, since tox already uses
coverage runinstead. While we are at it, we can also drop pytest-cov from the test dependencies. One less wheel for tox to download and install.The timeout option is moved to tox.
Both of these options add additional dependencies for running
pytestoutside of tox, which may sometimes be desired if you really know what you are doing. There is no way to disable them other than by patching out the addopts configuration. Best to specify this only in tox, which is designed to set up the appropriate environments already.Bug: https://bugs.gentoo.org/922192