Skip to content

Conversation

@essweine
Copy link
Contributor

This PR is actually a conglomeration of several things:

  • I had to update join tasks to join on update rather than complete to make anything work
  • stop inserting loop reset tasks (at the time I hadn't decided whether removing them from the serialization was worthwhile)
  • update timers to accommodate DST (the workflow I picked to test serialization migration had a timer and some of the other tests were failing too; normally I would create a separate PR for this kind of thing, but I'm in a rush at the moment and it was a a very simple change)
  • deal with loop resets in existing serialized workflows

Copy link
Contributor

@jbirddog jbirddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@danfunk danfunk merged commit f162aac into main Mar 15, 2023
@danfunk danfunk deleted the feature/remove-loop-reset branch March 15, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants