Improve greenfield doctor guidance - #13
Conversation
|
@coderabbitai review |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
ChangesDoctor readiness reporting
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bin/ultimate-agent-stack.mjs`:
- Around line 2122-2137: Update the firstBaselinePending condition near
configFailure and onboardingFailure to validate failure details, not just report
names: allow only the expected Git and approval failure details required for the
“Almost ready” state, while preserving pending onboarding and configuration
prerequisites. Add regression coverage for unexpected git,
configuration-approval, and check-approval failures so they retain stronger
statuses.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 063e2adf-be14-417f-95ce-b86b55f77d58
📒 Files selected for processing (5)
CHANGELOG.mdREADME.mdbin/ultimate-agent-stack.mjsdocs/OPERATING_MANUAL.mdtest/agent-stack.test.mjs
|
@coderabbitai review |
✅ Action performedReview finished.
|
What changed
doctor --humanRoot cause
The human formatter treated only onboarding and approval failures as setup. A post-init empty folder also reports the deliberate
no project quality checks configuredvalidation failure and commonly a missing Git repository, so the formatter fell through to the generic broken-configuration message.Safety boundary
The new classification applies only when onboarding is still pending, the sole configuration error is the missing first check baseline, and every required failure is an expected setup item. Malformed configuration, protected-file drift, pending update reconciliation, missing tools, and all other failures retain their stronger status.
Validation
npm run release:checkpassed: 65/65 tests, package dry-run, and packed-install smokemarkdownlint-cli2@0.18.1git diff --checkpassedSummary by CodeRabbit
New Features
doctor --humannow reports “Almost ready” for newly initialized, empty projects while the first quality-check baseline is being created.Bug Fixes
Documentation