'git-hub' tool found at configure time is not necessarily the one used at runtime

[salewski]

This issue pertains to ads-github-tools-0.3.3 (and all previous versions).

The configure script looks for a program named git-hub on $PATH at configure time, but at runtime the invocation used is that for Git subcommands (git hub ...). That means the location of the git-hub program found at runtime is dependent upon the user's current $PATH rather than the $PATH as it was set at configure time.

We ought to be able to simply invoke git-hub directly, since the invocation as a Git subcommand does not provide any additional capability AFAIK. Will require some testing to confirm.

[salewski]

This issue has been fixed for ads-github-tools-0.3.4 (released 2022-10-16).

The blurb about it from our 'NEWS' file:

*** issue 78: "'git-hub' tool found at configure time is not necessarily the one used at runtime"

    https://github.com/salewski/ads-github-tools/issues/78

    In earlier versions of the 'ads-github-tools' project, the 'configure'
    script did look for a program named 'git-hub' on $PATH at configure time,
    but at runtime the invocation used was that for Git subcommands:

    :    git hub ...

    That meant the location of the 'git-hub' program found at runtime was
    dependent upon the user's current $PATH (and whatever other rules 'git'
    uses internally) rather than the $PATH as it was set at configure time.

    This behavior has been changed so that the program is invoked directly
    with the name 'git-hub' rather than as a 'git' subcommand.

    The only program affected by this change is
    'ads-github-fetch-all-upstreams'. The change does not result in any change
    to user-visible behavior.