repo-create: JSON string values not properly escaped

[salewski]

The ads-github-repo-create tool creates a small JSON document that gets POSTed to the GitHub v3 API to create a new repository. The JSON strings in that document are not properly escaped, so a user providing, say, a repo description string that contains double-quote chars will break the JSON encoding.

The strings in the generated JSON document should be properly escaped.

[salewski]

This issue has been fixed for ads-github-tools-0.3.3.

The blurb about it from our 'NEWS' file:

*** issue 64: "ads-github-repo-create: JSON string values not properly escaped"

    https://github.com/salewski/ads-github-tools/issues/64

    The 'ads-github-repo-create' tool shipped with ads-github-tools-0.3.2 (and
    earlier) did not properly escape JSON strings during new repo
    creation. When users supplied command line parameters that contained
    string values that would need such escaping in a JSON document, the
    program submitted JSON to the GitHub API that was not well-formed. That
    resulted in an HTTP 400 response, with the response body:

    :    {"message":"Problems parsing JSON","documentation_url":"https://docs.github.com/rest/reference/repos#create-a-repository-for-the-authenticated-user"}

    The program has been fixed to properly escape those string values.

[salewski]

Re-opening issue

The "here string" syntax (used in the fix to provided the input string to jq(1) to escape) always introduces a trailing newline char ('\n'). It gets properly escaped, but the string gets rejected by GitHub with the error message:

    "description control characters are not allowed"