Skip to content

ads-github-merge-all-upstreams: bogon REPO command line options fail silently #24

@salewski

Description

@salewski

This issue pertains to the ads-github-merge-all-upstreams tool from 'ads-github-tools' version 0.2.0.

The ads-github-merge-all-upstreams program accepts repository names on the command line, but invalid (i.e., misspelled) repository names trigger neither errors nor warnings.

This behavior could leave the user thinking that he has merged (and possibly pushed) the 'upstream' changes for a repo whose name he has actually fat-fingered. The tools should complain about repository names for which it is unable to merge. This should be true regardless of whether the repo name has been mistyped or the repo exists but is not a fork of an upstream repository (or if it is, but doesn't have the "upstream" remote defined, or similar).

    $ ads-github-merge-all-upstreams -p DOES-NOT-EXIST
    $ echo $?
    0

The above invocation should produce a message on stderr and the program should exit with a non-zero status.

Note that this issue is related issue #1, which was basically the same issue with a different tool (ads-github-fetch-all-upstreams).

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions