feat: Lazy iter - #112
Draft
JonathanWoollett-Light wants to merge 3 commits into
Draft
Conversation
added 3 commits
July 14, 2023 11:54
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Allowing a return value for the event closures among many things allows for proper error propagation. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
`wait` now returns an iterator that allows lazily evaluating event closures. This allows for returning an error when the 1st closure returns an error, rather than always needing to evaluate every closure. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
lazy-iter
branch
from
July 14, 2023 10:54
283b1ad to
5fd3a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
waitnow returns an iterator that allows lazily evaluating event closures. This allows for returning an error when the 1st closure returns an error, rather than always needing to evaluate every closure.Benchmarks
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.