Skip to content

cache the Range for gen_ascii_chars #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheIronBorn wants to merge 1 commit into from
Closed

cache the Range for gen_ascii_chars #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ pub trait Rng {
/// println!("{}", s);
/// ```
fn gen_ascii_chars<'a>(&'a mut self) -> AsciiGenerator<'a, Self> where Self: Sized {
AsciiGenerator { rng: self }
AsciiGenerator { rng: self, range: Range::new(0, 62) }
}

/// Return a random element from `values`.
Expand Down Expand Up @@ -667,6 +667,7 @@ impl<'a, T: Rand, R: Rng> Iterator for Generator<'a, T, R> {
#[derive(Debug)]
pub struct AsciiGenerator<'a, R:'a> {
rng: &'a mut R,
range: Range<usize>,
}

impl<'a, R: Rng> Iterator for AsciiGenerator<'a, R> {
Expand All @@ -677,7 +678,7 @@ impl<'a, R: Rng> Iterator for AsciiGenerator<'a, R> {
b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\
abcdefghijklmnopqrstuvwxyz\
0123456789";
Some(*self.rng.choose(GEN_ASCII_STR_CHARSET).unwrap() as char)
Some(GEN_ASCII_STR_CHARSET[self.range.ind_sample(&mut self.rng)] as char)
}
}

Expand Down