rational: make sure Hash agrees with Eq#311
Merged
bors[bot] merged 1 commit intorust-num:masterfrom Jul 10, 2017
Merged
Conversation
Member
Author
|
Technically this is a breaking change, because the former derived (I don't actually need |
We can't use a derived `Hash` when we have a manual `Eq`, because we need to uphold the invariant `a == b` → `h(a) == h(b)`. Since `Eq` doesn't require them to be in reduced form, `Hash` also needs to be normalized.
Member
Author
|
There's not even a way to create a Thanks to @mbrubeck for reviewing this with me on IRC. bors r+ |
bors Bot
added a commit
that referenced
this pull request
Jul 10, 2017
311: rational: make sure Hash agrees with Eq r=cuviper We can't use a derived `Hash` when we have a manual `Eq`, because we need to uphold the invariant `a == b` → `h(a) == h(b)`. Since `Eq` doesn't require them to be in reduced form, `Hash` also needs to be normalized. Fixes #310.
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use a derived
Hashwhen we have a manualEq, because weneed to uphold the invariant
a == b→h(a) == h(b). SinceEqdoesn't require them to be in reduced form,
Hashalso needs to benormalized.
Fixes #310.