Skip to content

Define extended GCD, combined GCD+LCM#19

Merged
bors[bot] merged 9 commits intorust-num:masterfrom
strake:gcd
Apr 25, 2019
Merged

Define extended GCD, combined GCD+LCM#19
bors[bot] merged 9 commits intorust-num:masterfrom
strake:gcd

Conversation

@strake
Copy link
Contributor

@strake strake commented Dec 18, 2018 •
edited
Loading

No description provided.

@strake strake force-pushed the gcd branch 5 times, most recently from 6accdbc to f6f06f8 Compare December 19, 2018 05:43
@strake
Copy link
Contributor Author

strake commented Mar 21, 2019

Rebased, PTAL

cuviper
cuviper requested changes Mar 29, 2019
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cargo fmt this, and if it skips the macro impls, please format them manually.

cc #10 and #12 that overlap this PR.

src/lib.rs Outdated
Copy link
Member

@cuviper cuviper Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use separate x and y, so we can document it something like this:

Bézout's identity — Let a and b be integers with greatest common divisor d. Then, there exist integers x and y such that ax + by = d.

Then we also don't have to worry about array_clone.

src/lib.rs Outdated
Copy link
Member

@cuviper cuviper Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's a little annoying to have SubAssign in the API just for this, and AFAICT it's only needed because you're working through &mut. If the closure used values instead, or if you just flattened these three calls, then you could move and then reassign r.0 just fine.

Copy link
Member

@cuviper cuviper Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should require Signed though -- I believe it's useless for unsigned integers, since one of the coefficients must be negative, except the degenerate case with zeros.

@strake
Copy link
Contributor Author

strake commented Apr 10, 2019

@cuviper All done, PTAL

@cuviper
Copy link
Member

cuviper commented Apr 25, 2019

Thanks!

bors r+

bors bot added a commit that referenced this pull request Apr 25, 2019
@bors @strake @cuviper
Merge #19
fc93e11 
19: Define extended GCD, combined GCD+LCM r=cuviper a=strake



Co-authored-by: M Farkas-Dyck <strake888@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 25, 2019

Build failed

@cuviper
Copy link
Member

cuviper commented Apr 25, 2019

Sorry, that was my fault.

bors r+

bors bot added a commit that referenced this pull request Apr 25, 2019
@bors @strake @cuviper
Merge #19
4271330 
19: Define extended GCD, combined GCD+LCM r=cuviper a=strake



Co-authored-by: M Farkas-Dyck <strake888@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 25, 2019

Build succeeded

@bors bors bot merged commit a169ee2 into rust-num:master Apr 25, 2019
@cuviper cuviper mentioned this pull request May 20, 2019
Closed
@cuviper cuviper mentioned this pull request Dec 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strake @cuviper @error256

Comments