Arithmetic operations B @ A are now only implemented for owned storage B
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `B` Previously, operators like +, - etc, denoted by @ in general, were implemented so that they allowed ArrayViewMut as the left hand side operand. It would update the data in the view, and return the same view. This can be confusing, and was suggested by @SuperFluffy to be removed. We tentatively remove those implementations here. To work around B @ A not being allowed for a mutable view `B`, you can use B @= A instead, or the corresponding stable methods iadd, imul, etc. Please see the Arithmetic Operations overview in the `ArrayBase` docs for an easy to read overview. Fixes #83
bluss
added a commit
that referenced
this pull request
Feb 28, 2016
Arithmetic operations B @ A are now only implemented for owned storage `B`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the Arithmetic Operations overview in the
ArrayBasedocsfor an easy to read overview.
Fixes #83