Skip to content

Internal module names for x86 architecture intrinsics  #169

@gnzlbg

Description

@gnzlbg

In #166 I've added some architecture intrinsics (e.g. the cpuid intrinsic) to a misc module in x86.

Our internal module names are private and do not affect users, but IMO the name misc is pretty bad and we should group these intrinsics in a more consistent way.

We could name those modules .../i386/i486/i586/i686/... instead.

The main issue I have with this is that, for example, detecting i686 using target feature leads to:

if cfg!(all(target_arch = "x86", not(target_feature = "sse2"))) {

}

is IMO a bit messy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions