Ensure link to compare page is always present#1291
Merged
Conversation
Kobzol
approved these changes
Apr 11, 2022
Member
Kobzol
left a comment
There was a problem hiding this comment.
Great :) I wonder if we should also generate -perf-regression even if no relevant results were found? E.g. a previous run might have generated a regression, and another one (after some change) could return no relevant changes.
Member
Author
That's a great point. I don't believe we ever did that though so let's tackle that in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1289
After some refactoring, we accidentally removed the link to the compare page when the results of a perf run were not relevant (see here for an example). This adds it back and simplifies how we build up the message to be posted on GitHub.