Re-add rust-analyzer as a subtree#99465
Closed
fasterthanlime wants to merge 10000 commits into
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Disclaimer: THIS IS A DRAFT, NOBODY APPROVED THIS, I'M JUST TRYING THINGS OUT)
This PR shows what it would take to make rust-lang/rust-analyzer#12815 happen.
I simply removed the submodule:
And added a subtree, after patching my local git-subtree, following the rustc dev guide:
I then cherry-picked some commits from:
The goal being to avoid regressions to rust-analyzer's
proc-macro-srvcomponent by running its test suite in CI.As a reminder, nobody approved this, this is me just doing research to try and save time if and when that option is chosen.