Add type_name info to [TIMING] log output#96106
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
I think to avoid printing the name twice, you can move this formatting underneath (edit: we ended up not doing this since it would have required implementing Debug for each and every Step.) @rustbot label +S-waiting-on-author -S-waiting-on-review +A-rustbuild |
|
@rustbot ready |
|
r=me with the two nits |
|
@jihiggins you can use @rustbot ready after making changes to let Mark know it's ready for review. |
0a685c1 to
0fea007
Compare
|
@bors r+ rollup=iffy Thanks! I've gone ahead and also squashed commits here. |
|
📌 Commit 0fea007 has been approved by |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (fedbe5d): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. |
Adds type_name to the [TIMING] log output:
Not sure if that's the best way to format it. Thought about replacing the struct's name with the type_name output, but that feels kind of hacky?
Closes #96060