ci: add a pr builder to test tools when submodules are updated#62560
Merged
Conversation
Member
Author
|
Do not merge this yet, I want to push test commits that change submodules to make sure all of this works. |
cc1fcbf to
0182f82
Compare
The builder will skip time consuming tasks (like the actual tests) when it detects no updated submodules.
105c6b0 to
2d2dcb0
Compare
Member
Author
|
Ok this works fine and it's ready for a review. Commit with submodule update - Commit without submodule updates (41 seconds) |
Member
|
@bors: r+ Nice! |
Collaborator
|
📌 Commit 2d2dcb0 has been approved by |
RalfJung
reviewed
Jul 11, 2019
| set -e | ||
| # Submodules pseudo-files inside git have the 160000 permissions, so when | ||
| # those files are present in the diff a submodule was updated. | ||
| if git diff HEAD^ | grep "^index .* 160000" >/dev/null 2>&1; then |
Member
There was a problem hiding this comment.
This looks like it only tests the last commit of the PR as opposed to all of them for changing submodules?
Member
Author
There was a problem hiding this comment.
This checks the merge commit, so any submodule change should be detected.
Member
There was a problem hiding this comment.
Ah, so HEAD^ will be the parent that's the old master, not the other parent. Makes sense.
I never know which side HEAD^ picks with merge commits...
Collaborator
bors
added a commit
that referenced
this pull request
Jul 12, 2019
…hton ci: add a pr builder to test tools when submodules are updated This PR adds the x86_64-gnu-tools builders to PRs where submodules are updated. Since it's not possible to *start* the builder only when submodule changes are detected, I opted into adding a "decider" task at the start of the job which sets the `SKIP_JOB` environment variable when submodules are not updated, and I gated the most time-consuming tasks (the actual build and artifacts upload) on the variable not being there. All of this is conditionally included in the `steps/run.yml` only when a template parameter is present, so it should only affect that builder on PRs. The cost for this should be a dummy builder running for 2/3 minutes for each PR, and we should be able to handle it. Fixes #61837 r? @alexcrichton
Collaborator
|
💔 Test failed - checks-azure |
Member
Author
|
@bors retry Spurious failure. |
Member
|
@bors p=3 |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 14, 2019
…hton ci: add a pr builder to test tools when submodules are updated This PR adds the x86_64-gnu-tools builders to PRs where submodules are updated. Since it's not possible to *start* the builder only when submodule changes are detected, I opted into adding a "decider" task at the start of the job which sets the `SKIP_JOB` environment variable when submodules are not updated, and I gated the most time-consuming tasks (the actual build and artifacts upload) on the variable not being there. All of this is conditionally included in the `steps/run.yml` only when a template parameter is present, so it should only affect that builder on PRs. The cost for this should be a dummy builder running for 2/3 minutes for each PR, and we should be able to handle it. Fixes #61837 r? @alexcrichton
Collaborator
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the x86_64-gnu-tools builders to PRs where submodules are updated.
Since it's not possible to start the builder only when submodule changes are detected, I opted into adding a "decider" task at the start of the job which sets the
SKIP_JOBenvironment variable when submodules are not updated, and I gated the most time-consuming tasks (the actual build and artifacts upload) on the variable not being there. All of this is conditionally included in thesteps/run.ymlonly when a template parameter is present, so it should only affect that builder on PRs.The cost for this should be a dummy builder running for 2/3 minutes for each PR, and we should be able to handle it.
Fixes #61837
r? @alexcrichton