Document while keyword#62462
Merged
Merged
Conversation
Centril
reviewed
Jul 7, 2019
Contributor
|
r? @Centril |
Contributor
|
@JohnTitor If you go to "Files changed" you can batch apply suggestions into one commit. Can you squash the commits into one now (and run tidy because there may be some lines that are too long now...)? |
tesuji
reviewed
Jul 7, 2019
Member
Author
|
@Centril Oh, I didn't know that. I squashed and checked the change with tidy on my local. |
Contributor
|
r=me rollup when green. |
ghost
suggested changes
Jul 7, 2019
ghost
left a comment
There was a problem hiding this comment.
Otherwise it looks great.
Nice to have some documentation 👍
Member
Author
|
I added the changes suggested by @BO41 and removed unnecessary indents (L646). I hope that there is no problem with that... |
Contributor
|
Looks good :) (still r=me...) |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 559c3ec has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 8, 2019
Document `while` keyword This is a rework of rust-lang#60761. Closes rust-lang#60736 r? @dtolnay
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 8, 2019
Document `while` keyword This is a rework of rust-lang#60761. Closes rust-lang#60736 r? @dtolnay
bors
added a commit
that referenced
this pull request
Jul 8, 2019
Rollup of 5 pull requests Successful merges: - #62356 (Implement Option::contains and Result::contains) - #62462 (Document `while` keyword) - #62472 (Normalize use of backticks in compiler messages p2) - #62477 (Re-add bootstrap attribute to libunwind for llvm-libunwind feature) - #62478 (normalize use of backticks for compiler messages in librustc_codegen) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of #60761.
Closes #60736
r? @dtolnay