ci: use a custom android sdk manager with pinning and mirroring#59926
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 15, 2019
Merged
ci: use a custom android sdk manager with pinning and mirroring#59926bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
Could you describe a bit what the process would look like to upgrade these images? (ideally in comments in the code as well!) I'd just want to make sure that's documented somewhere and otherwise lgtm |
Member
Author
|
There is already a bit of docs in the comments. Should I expand it or move it somewhere else? The gist of it (for example to update the emulator) is: |
Member
|
Yeah I was wondering how we'd update all the hashes, but I see the words now and that seems reasonable to me, sorry for the oversight! @bors: r+ |
Collaborator
|
📌 Commit 4e920f2 has been approved by |
Member
Author
|
Do not rollup this. |
Contributor
|
@bors p=2 Putting behind a r0llup and its constituent PRs. |
Collaborator
bors
added a commit
that referenced
this pull request
Apr 15, 2019
ci: use a custom android sdk manager with pinning and mirroring Google's own sdkmanager has two issues that make it unsuitable for us: * Mirroring has to be done manually, which is annoying because we need to figure out on our own all the URLs to copy (I couldn't find any documentation when building this PR, had to use mitmproxy). * There is no support for pinning, which means an update on Google's side can break our CI, as it happened multiple times. This PR replaces all our usage of sdkmanager with a custom Python script which mimics its behavior, but with the two issues fixes. sdkmanager's logic for installing packages is thankfully very simple: the package name (like `system-images;android-18;default;armeabi-v7a`) is the directory where the package should live (with `;` replaced with `/`), so to install a package we only need to extract its contents in the right directory. r? @alexcrichton cc @kennytm fixes #59778
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google's own sdkmanager has two issues that make it unsuitable for us:
This PR replaces all our usage of sdkmanager with a custom Python script which mimics its behavior, but with the two issues fixes.
sdkmanager's logic for installing packages is thankfully very simple: the package name (like
system-images;android-18;default;armeabi-v7a) is the directory where the package should live (with;replaced with/), so to install a package we only need to extract its contents in the right directory.r? @alexcrichton
cc @kennytm
fixes #59778