Add a feature gate for nested uses of impl Trait#46888
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 24, 2017
Merged
Conversation
nikomatsakis
requested changes
Dec 20, 2017
Contributor
There was a problem hiding this comment.
can we add a test for fn bad(x: impl Into<impl Debug>) -- it occurs to me that nested syntax in this position is also "not great" for the same reason. Though perhaps a mite less bad in that it's more clear how we would allow those types to be specified in the future.
Member
Author
There was a problem hiding this comment.
Oh, I purposefully made that work, so that test would fail. I will make the change.
4f8f8dd to
99a1460
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 99a1460 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #46531) made this pull request unmergeable. Please resolve the merge conflicts. |
99a1460 to
c026d19
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit c026d19 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…=nikomatsakis Add a feature gate for nested uses of `impl Trait` This allows us to delay stabilization of nested `impl Trait` until we have a plan to solve the problem posed [here](rust-lang#34511 (comment)). r? @nikomatsakis
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…=nikomatsakis Add a feature gate for nested uses of `impl Trait` This allows us to delay stabilization of nested `impl Trait` until we have a plan to solve the problem posed [here](rust-lang#34511 (comment)). r? @nikomatsakis
Collaborator
bors
added a commit
that referenced
this pull request
Dec 24, 2017
Add a feature gate for nested uses of `impl Trait` This allows us to delay stabilization of nested `impl Trait` until we have a plan to solve the problem posed [here](#34511 (comment)). r? @nikomatsakis
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to delay stabilization of nested
impl Traituntil we have a plan to solve the problem posed here.r? @nikomatsakis