Fix off-by-one error in column number in explain_span.#42062
Merged
bors merged 1 commit intorust-lang:masterfrom May 21, 2017
Merged
Fix off-by-one error in column number in explain_span.#42062bors merged 1 commit intorust-lang:masterfrom
explain_span.#42062bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
Ordinarily, I'd say let's add a test, but I'm not sure it's worth it in this particular case, since I think those error messages are fairly fragile and likely to be changed. |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit f24b168 has been approved by |
Contributor
Author
|
Ok, turns out there were tests covering this. I'll push an update once I've fixed them all. |
f24b168 to
eb703f7
Compare
Contributor
Author
|
Okay, I've fixed the tests and amended the commit. |
Member
|
@bors r= nikomatsakis |
Collaborator
|
📌 Commit eb703f7 has been approved by `` |
Member
Collaborator
|
📌 Commit eb703f7 has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 20, 2017
…omatsakis Fix off-by-one error in column number in `explain_span`. Fixes rust-lang#41938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41938