std: Update compiler-rt for more ABI fixes#37691
Merged
Merged
Conversation
This update of compiler-rt includes rust-lang/compiler-rt#26 which provides a targeted fix to the powisf2 intrinsics to keep rust-lang#37559 fixed but also address the new issue of rust-lang#37630. I've also [written up my thoughts][1] on why it appears that this is the correct fix for now (hoepfully at least). Closes rust-lang#37630 [1]: rust-lang/compiler-rt#26 (comment)
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
Nominating for beta as this is a stable-to-stable regression |
Contributor
|
@bors r+ p=1 |
Collaborator
|
📌 Commit 2743128 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 11, 2016
std: Update compiler-rt for more ABI fixes This update of compiler-rt includes rust-lang/compiler-rt#26 which provides a targeted fix to the powisf2 intrinsics to keep #37559 fixed but also address the new issue of #37630. I've also [written up my thoughts][1] on why it appears that this is the correct fix for now (hoepfully at least). Closes #37630 [1]: rust-lang/compiler-rt#26 (comment)
Collaborator
Contributor
|
@alexcrichton Has this landed on beta yet? I don't see it in the commit log. |
Member
Author
|
@rillian AFAIK no |
Contributor
|
@alexcrichton Ok, thanks for checking. Does the beta-accepted tag mean bors will land it, or should I submit a PR? We want this so we can update the gecko builders. |
This was referenced Nov 16, 2016
Member
Author
|
Ah this doesn't happen automatically, we do so periodically from time to time. I've done so here: #37815 |
Contributor
|
Thanks Alex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update of compiler-rt includes rust-lang/compiler-rt#26 which provides a
targeted fix to the powisf2 intrinsics to keep #37559 fixed but also address
the new issue of #37630. I've also written up my thoughts on why it appears
that this is the correct fix for now (hoepfully at least).
Closes #37630