Fix ios / compiler-rt condition in makefile#34627
Closed
TimNN wants to merge 1 commit intorust-lang:masterfrom
Closed
Fix ios / compiler-rt condition in makefile#34627TimNN wants to merge 1 commit intorust-lang:masterfrom
TimNN wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
This was not the correct fix and I probably misunderstood the current makefile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #34055 and caused a regression in the ios builds.
Closes #34617.
I'm currently running a local build to verify that this fixes the regression but preliminary tests indicate that the
GCCISH_CFLAGSare now properly forwarded tocmakewhich they previously were not (which was the cause of the regression as far as I can tell).