Skip to content

doc: "x" is used as variable name on this API, so avoid using it here#30909

Merged
bors merged 1 commit into
rust-lang:masterfrom
tshepang:a-better-name
Jan 15, 2016
Merged

doc: "x" is used as variable name on this API, so avoid using it here#30909
bors merged 1 commit into
rust-lang:masterfrom
tshepang:a-better-name

Conversation

@tshepang
Copy link
Copy Markdown
Member

For a moment, I got confused by thinking the summary was referring to the same x

@rust-highfive
Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thank you for all these improvements!

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 14, 2016

📌 Commit 80d2be9 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
For a moment, I got confused by thinking the summary was referring to the same `x`
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
For a moment, I got confused by thinking the summary was referring to the same `x`
@tshepang
Copy link
Copy Markdown
Member Author

Thanks @steveklabnik for you quick responses

bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit 80d2be9 into rust-lang:master Jan 15, 2016
@tshepang tshepang deleted the a-better-name branch January 15, 2016 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants