Specify Microsoft Windows and Mac OS X explicitly#29528
Conversation
When referring to the different shared library extensions, specify the OS explicitly.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ rollup |
|
📌 Commit 900f36f has been approved by |
|
Thanks @amitsaha ! |
|
⌛ Testing commit 900f36f with merge 358b321... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Tue, Nov 3, 2015 at 11:29 AM, bors notifications@github.com wrote:
|
|
Thanks for considering this as an improvement! |
…s-minor, r=nikomatsakis When referring to the different shared library extensions, specify the OS explicitly.
…nikomatsakis When referring to the different shared library extensions, specify the OS explicitly.
When referring to the different shared library extensions, specify the OS explicitly.