Rerun the goal with doubled recursion limit even if the goal has ty vars

[adwinwhite]

Fix the bevy_render regression and more in the next solver crater run.

The problem is that we don't rerun the root goal with doubled recursion limit if it contains ty vars.
But we actually need the evaluation response to resolve the ty vars. So the type inference fails.

[adwinwhite]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 9c22651 (9c226517f39ac2eb73245bb4d6dcf5233fb5df63)
Base parent: 8ab9fdf (8ab9fdff5a91b9f2b5ed57fb0275452d9a0d0280)

[rust-timer]

Finished benchmarking commit (9c22651): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.9%, secondary 5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	5.8%	[5.8%, 5.8%]	1
Improvements ✅ (primary)	-2.7%	[-5.0%, -0.7%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-5.0%, 0.4%]	4

Cycles

Results (primary -0.3%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.9%]	3
Regressions ❌ (secondary)	1.0%	[0.5%, 3.4%]	7
Improvements ✅ (primary)	-1.0%	[-1.7%, -0.5%]	4
Improvements ✅ (secondary)	-1.5%	[-3.9%, -0.4%]	9
All ❌✅ (primary)	-0.3%	[-1.7%, 0.9%]	7

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	38
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	42
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	38

Bootstrap: 492.09s -> 490.546s (-0.31%)
Artifact size: 390.63 MiB -> 390.52 MiB (-0.03%)

[lcnr]

alright, can you make sure this fixes the issues and add them as test, then r=me I guess 🤣

[rustbot]

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 75 candidates
• Random selection from 19 candidates

[adwinwhite]

Sorry, forgot to
r? lcnr
The bevy_render crate compiles without errors now.
@bors r=lcnr rollup

[rust-bors]

📌 Commit 1489e47 has been approved by lcnr

It is now in the queue for this repository.