clean up handling of paths in mgca - #160216
Open
khyperia wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
khyperia
force-pushed
the
gca-path-cleanup
branch
from
July 30, 2026 14:56
838d04a to
8dda2c6
Compare
khyperia
force-pushed
the
gca-path-cleanup
branch
from
July 31, 2026 07:44
8dda2c6 to
5b41ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related tracking issue: #132980
Handling of ambiguous type-or-constant argument paths was really wonky and distinct from the regular
can_lower_expr_to_const_arg_directlowering paths. Clean that up and unify it, as discussed here #158479 (comment)Also, do a bunch of other little cleanups at the same time while I'm here:
I am unsure if/how this changes behavioradded a test,direct-const-arg-correct-rib.rs) - this was discussed here allow mGCA const arguments to fall back to anon consts #158617 (comment)direct_const_arg!(_)inferring to a type - this test should have been added in implement #![feature(macroless_generic_const_args)] #159058 which added this behavior (well, changed the behavior from an ICE to inferring to a type)r? @BoxyUwU