Split non-local `semicolon_in_expressions_from_macros` into a separate lint by joshtriplett · Pull Request #159700 · rust-lang/rust

joshtriplett · 2026-07-22T03:26:24Z

The new handling for non-local macros in
semicolon_in_expressions_from_macros produces new deny-by-default
lints on various existing crates, which have not previously received
warnings because prior Rust versions suppressed them. Split those out
into a new semicolon_in_expressions_from_non_local_macros lint, and
make that one warn-by-default (and FCW warn-in-deps), rather than
deny-by-default, to give the ecosystem time to adapt.

This reintroduces the is_local tracking from commit
9192337.

rustbot · 2026-07-22T03:26:29Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 17 candidates

joshtriplett · 2026-07-22T03:29:20Z

Needs lang approval for the new lint. Hoping to get that approval in tomorrow's (2026-07-22) lang meeting.

This is needed due to many new errors in the ecosystem; we need to give people time to fix those, and not (effectively) go directly from not emitting a lint at all to emitting a deny-by-default lint.

…e lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

…ros` The automatic mechanism to produce lint examples won't work, since this lint needs a separate crate, so add a `rust,ignore` example and manually provide the compiler output.

traviscross · 2026-07-22T15:27:28Z

Proposed to accept this and waive any part of our 10-day FCP period necessary to get this into the next release.

@rfcbot fcp merge lang

rust-rfcbot · 2026-07-22T15:27:30Z

@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

tmandry · 2026-07-22T15:27:41Z

@rfcbot reviewed

nikomatsakis · 2026-07-22T15:28:01Z

@rfcbot reviewed

rust-rfcbot · 2026-07-22T15:28:09Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rust-bors · 2026-07-25T12:48:04Z

💔 Test for b7b0eb7 failed: CI. Failed job:

auto - dist-x86_64-netbsd (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-07-25T13:39:18Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jhpratt · 2026-07-25T16:49:50Z

@bors treeclosed=1000 continued CI outage

rust-bors · 2026-07-25T16:49:53Z

Tree closed for PRs with priority less than 1000.

JonathanBrouwer · 2026-07-25T17:34:55Z

@bors retry
Spurious

…ons-from-non-local-macros, r=petrochenkov Split non-local `semicolon_in_expressions_from_macros` into a separate lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

…uwer Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159785 (Share _Unwind_Exception definition between native and wasm) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`)

…ons-from-non-local-macros, r=petrochenkov Split non-local `semicolon_in_expressions_from_macros` into a separate lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

…uwer Rollup of 25 pull requests Successful merges: - #159825 (codegen: handle OperandValue::Uninit in codegen_return_terminator) - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`)

…ons-from-non-local-macros, r=petrochenkov Split non-local `semicolon_in_expressions_from_macros` into a separate lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #152439 (Fix typos and grammar in library documentation) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`)

Rollup merge of #159700 - joshtriplett:semicolon-in-expressions-from-non-local-macros, r=petrochenkov Split non-local `semicolon_in_expressions_from_macros` into a separate lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

Rollup of 25 pull requests Successful merges: - rust-lang/rust#138618 (Support using const pointers in asm `const` operand) - rust-lang/rust#157962 (Lower paths to functions in const args as ConstKind::Error) - rust-lang/rust#158709 (rustdoc: warn on improperly interleaved HTML/MD) - rust-lang/rust#159174 (Fix implicit_provenance_casts warnings on Xous) - rust-lang/rust#159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - rust-lang/rust#159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - rust-lang/rust#159673 (bootstrap: forward -fdebug-prefix-map when using cc) - rust-lang/rust#159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - rust-lang/rust#159720 (document #[global_allocator] constraints) - rust-lang/rust#159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - rust-lang/rust#159738 (implement `CovariantUnsafeCell`) - rust-lang/rust#159740 (reuse regular exported_non_generic_symbols logic in Miri) - rust-lang/rust#159780 (check `extern "custom"` function pointers) - rust-lang/rust#159786 (rustdoc-js: ignore editor temp files in test folder discovery) - rust-lang/rust#159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - rust-lang/rust#152439 (Fix typos and grammar in library documentation) - rust-lang/rust#155388 (stepping into where-clauses during normalization may be productive) - rust-lang/rust#155914 (when bailing on ambiguity, don't force other results to ambig) - rust-lang/rust#159204 (Add support to caller_location to rustc_public) - rust-lang/rust#159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - rust-lang/rust#159676 (Update wasm-component-ld to 0.5.27) - rust-lang/rust#159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - rust-lang/rust#159730 (allow accessing the contents of UnsafeCell without going through get) - rust-lang/rust#159809 (Avoid `#[target_features]`) - rust-lang/rust#159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`)

joshtriplett assigned petrochenkov Jul 22, 2026

rustbot assigned wesleywiser Jul 22, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2026

This comment has been minimized.

Sign in to view

joshtriplett added 2 commits July 21, 2026 23:36

Add (manual) example for `semicolon_in_expressions_from_non_local_mac…

c1a4b72

…ros` The automatic mechanism to produce lint examples won't work, since this lint needs a separate crate, so add a `rust,ignore` example and manually provide the compiler output.

joshtriplett force-pushed the semicolon-in-expressions-from-non-local-macros branch from d35b967 to c1a4b72 Compare July 22, 2026 06:37

joshtriplett mentioned this pull request Jul 22, 2026

semicolon_in_expressions_from_macros: Lint on non-local macros too #159222

Merged

traviscross added the P-lang-drag-0 Lang team prioritization drag level 0.https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang. label Jul 22, 2026

petrochenkov added S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 22, 2026

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 22, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026

JonathanBrouwer mentioned this pull request Jul 25, 2026

Rollup of 25 pull requests #159920

Closed

JonathanBrouwer mentioned this pull request Jul 25, 2026

Rollup of 25 pull requests #159926

Closed

This was referenced Jul 26, 2026

Rollup of 25 pull requests #159941

Closed

Rollup of 25 pull requests #159942

Merged

rust-bors Bot merged commit 2ff6491 into rust-lang:main Jul 26, 2026
13 of 14 checks passed

rustbot added this to the 1.99.0 milestone Jul 26, 2026

joshtriplett deleted the semicolon-in-expressions-from-non-local-macros branch July 27, 2026 21:02

joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 27, 2026

rustbot mentioned this pull request Jul 27, 2026

Tracking issue for release notes of #159700: Split non-local semicolon_in_expressions_from_macros into a separate lint #160029

Open

Uh oh!

Uh oh!

Conversation

joshtriplett commented Jul 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

joshtriplett commented Jul 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

traviscross commented Jul 22, 2026

Uh oh!

rust-rfcbot commented Jul 22, 2026 • edited by scottmcm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmandry commented Jul 22, 2026

Uh oh!

nikomatsakis commented Jul 22, 2026

Uh oh!

rust-rfcbot commented Jul 22, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

rust-log-analyzer commented Jul 25, 2026

Uh oh!

jhpratt commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

JonathanBrouwer commented Jul 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

joshtriplett commented Jul 22, 2026 •

edited by rustbot

Loading

rust-rfcbot commented Jul 22, 2026 •

edited by scottmcm

Loading