Skip to content

Add regression test for #101363 - #159348

Closed
SumkaKiller wants to merge 1 commit into
rust-lang:mainfrom
SumkaKiller:add-test-101363
Closed

Add regression test for #101363#159348
SumkaKiller wants to merge 1 commit into
rust-lang:mainfrom
SumkaKiller:add-test-101363

Conversation

@SumkaKiller

@SumkaKiller SumkaKiller commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Adds a regression test for #101363: borrowing a block expression inside
a tuple variant constructor in a const now compiles. Test passes locally.

Closes #101363

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@TaKO8Ki

TaKO8Ki commented Jul 15, 2026

Copy link
Copy Markdown
Member

A regression test for 101363 has already been added in #155882. What is this pr for?

@TaKO8Ki

TaKO8Ki commented Jul 15, 2026

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad diagnostics when constructing tuple variant with static ref inside const

3 participants