Skip to content

Add codegen test for signed nonzero matches - #159129

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-signed-nonzero-matches
Jul 20, 2026
Merged

Add codegen test for signed nonzero matches#159129
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
amirHdev:add-codegen-test-signed-nonzero-matches

Conversation

@amirHdev

@amirHdev amirHdev commented Jul 11, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Closes #84311

@amirHdev
chore: add codegen test for signed nonzero matches
cf92b22 
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@amirHdev

amirHdev commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

r? @nnethercote

@rustbot rustbot assigned nnethercote and unassigned petrochenkov Jul 13, 2026
@nnethercote

nnethercote commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

You have done a few of these codegen tests now. I'm curious how/why you got into doing them?

@rust-bors

rust-bors Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cf92b22 has been approved by nnethercote

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026
@jhpratt jhpratt mentioned this pull request Jul 20, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 20, 2026
@bors
Auto merge of #159588 - jhpratt:rollup-52xc4vm, r=jhpratt
14ead7d 
Rollup of 2 pull requests

Successful merges:

 - #158916 (Emit all borrowck errors at the end of borrowck)
 - #159129 (Add codegen test for signed nonzero matches)
@amirHdev

amirHdev commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

You have done a few of these codegen tests now. I'm curious how/why you got into doing them?

Thanks! I’ve been learning more about compiler optimizations, LLVM IR and assembly because I’d like to contribute more deeply to rustc. these codegen tests felt like a good way to learn the compiler pipeline

@rust-bors
rust-bors Bot merged commit 2408dfe into rust-lang:main Jul 20, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 20, 2026
rust-timer added a commit that referenced this pull request Jul 20, 2026
@rust-timer
Unrolled build for #159129
717a8bd 
Rollup merge of #159129 - amirHdev:add-codegen-test-signed-nonzero-matches, r=nnethercote

Add codegen test for signed nonzero matches

Closes #84311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

matches!(n, -1 | 1) for signed NonZero suboptimal

4 participants

@amirHdev @rustbot @nnethercote @petrochenkov